Skip to content

Use version.txt to determine torchvision version in CMakeLists.txt #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2021
Merged

Use version.txt to determine torchvision version in CMakeLists.txt #3381

merged 2 commits into from
Feb 11, 2021

Conversation

bmanga
Copy link
Contributor

@bmanga bmanga commented Feb 11, 2021

Closes #3358

@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited
Loading

Codecov Report

Merging #3381 (34a4bba) into master (059b19b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3381   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         105      105           
  Lines        9716     9716           
  Branches     1561     1561           
=======================================
  Hits         7268     7268           
  Misses       1961     1961           
  Partials      487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059b19b...34a4bba. Read the comment docs.

datumbox
datumbox approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datumbox datumbox merged commit 5a31545 into pytorch:master Feb 11, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 12, 2021
@datumbox @facebook-github-bot
Use version.txt to determine torchvision version in CMakeLists.txt (#…
7bf115e 
…3381)

Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: mthrok

Differential Revision: D26422442

fbshipit-source-id: 5dc3c668272becc037244fba6aaafb7499eaa7ff
@fmassa
Copy link
Member

fmassa commented Feb 16, 2021

Thanks @bmanga for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

discrepancies between TorchVisionConfigVersion.cmake to git branch

4 participants

@bmanga @fmassa @datumbox @facebook-github-bot