Skip to content

Fix test flakiness on test_random_erasing() #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2021
Merged

Fix test flakiness on test_random_erasing() #3386

merged 5 commits into from
Feb 12, 2021

Conversation

datumbox
Copy link
Contributor

Fixes:

test_random_erasing (test_transforms.Tester) ... FAIL
======================================================================
FAIL: test_random_erasing (test_transforms.Tester)
====================== 2 lines skipped ======================
  File "./test_transforms.py", line 1965, in test_random_erasing
    self.assertTrue(aspect_ratio > 1. / 3. and aspect_ratio < 3. / 1.)
AssertionError: False is not true

@datumbox datumbox requested a review from NicolasHug February 12, 2021 09:23
NicolasHug
NicolasHug reviewed Feb 12, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #3386 (1a778ae) into master (2857536) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3386   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         105      105           
  Lines        9714     9714           
  Branches     1561     1561           
=======================================
  Hits         7267     7267           
  Misses       1960     1960           
  Partials      487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2857536...1a778ae. Read the comment docs.

@datumbox datumbox merged commit 103eec5 into pytorch:master Feb 12, 2021
@datumbox datumbox deleted the test/fix_flakiness branch February 12, 2021 10:18
facebook-github-bot pushed a commit that referenced this pull request Feb 12, 2021
@datumbox @NicolasHug @facebook-github-bot
Fix test flakiness on test_random_erasing() (#3386)
9e5d4ee 
Summary:
* Fix test flakiness caused by rounding.

* Update test/test_transforms.py

* Styles

Reviewed By: mthrok

Differential Revision: D26422443

fbshipit-source-id: b3b2e28feef820a65170b7c2529db8b0701c3ca7

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @NicolasHug @facebook-github-bot