Skip to content

Fix incorrectly frozen BN on ResNet FPN backbone #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2021
Merged

Fix incorrectly frozen BN on ResNet FPN backbone #3396

merged 3 commits into from
Feb 15, 2021

Conversation

datumbox
Copy link
Contributor

Fixes #3394

@datumbox datumbox requested a review from fmassa February 15, 2021 11:08
@datumbox datumbox force-pushed the bugfix/resnet_fpn_bn_freeze branch from 05b65d0 to ed5961b Compare February 15, 2021 11:15
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited
Loading

Codecov Report

Merging #3396 (ed5961b) into master (af97ec2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3396      +/-   ##
==========================================
+ Coverage   74.80%   74.82%   +0.01%     
==========================================
  Files         105      105              
  Lines        9714     9721       +7     
  Branches     1561     1563       +2     
==========================================
+ Hits         7267     7274       +7     
  Misses       1960     1960              
  Partials      487      487
Impacted Files Coverage Δ
torchvision/models/detection/backbone_utils.py 88.40% <100.00%> (+0.34%) ⬆️
torchvision/ops/boxes.py 87.77% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067b9dc...900dbe2. Read the comment docs.

@datumbox datumbox requested a review from vfdev-5 February 15, 2021 14:01
vfdev-5
vfdev-5 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @datumbox !

@datumbox datumbox merged commit eca37cf into pytorch:master Feb 15, 2021
@datumbox datumbox deleted the bugfix/resnet_fpn_bn_freeze branch February 15, 2021 14:23
facebook-github-bot pushed a commit that referenced this pull request Feb 23, 2021
@fmassa @facebook-github-bot
Fix incorrectly frozen BN on ResNet FPN backbone (#3396)
58ab28d 
Summary:
* Avoid freezing bn1 if all layers are trainable.

* Remove misleading comments.

Reviewed By: NicolasHug

Differential Revision: D26605317

fbshipit-source-id: cebb26bde8bb45d738258c2deea4e9a878ee54fd
@datumbox datumbox added the bug label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
bug cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResNet FPN backbone
3 participants
@datumbox @vfdev-5 @facebook-github-bot