Skip to content

Fix ternary operator to decide to store an image in Grayscale or RGB #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix ternary operator to decide to store an image in Grayscale or RGB #3553

merged 2 commits into from
Mar 12, 2021

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Mar 11, 2021

Fixes #3526

@andfoy andfoy self-assigned this Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021 •
edited
Loading

Codecov Report

Merging #3553 (1bb0498) into master (9a08e47) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3553      +/-   ##
==========================================
- Coverage   78.86%   78.86%   -0.01%     
==========================================
  Files         105      105              
  Lines        9752     9750       -2     
  Branches     1567     1567              
==========================================
- Hits         7691     7689       -2     
  Misses       1574     1574              
  Partials      487      487
Impacted Files Coverage Δ
torchvision/datasets/mnist.py 55.21% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e80296...37cc250. Read the comment docs.

datumbox
datumbox approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 9bccd5a into pytorch:master Mar 12, 2021
@andfoy andfoy deleted the fix_grayscale_loading branch March 12, 2021 18:10
@fmassa
Copy link
Member

fmassa commented Mar 12, 2021

@andfoy can you add a test for a grayscale image in a follow-up PR?

facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2021
@vincentqb @facebook-github-bot
[fbsync] Fix ternary operator to decide to store an image in Grayscal…
f0ff109 
…e or RGB (#3553)

Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: fmassa

Differential Revision: D27127992

fbshipit-source-id: 76ef726f854788ce71e785a838637e521d1f422c
@datumbox datumbox added bug and removed fix labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andfoy andfoy

Labels
bug cla signed module: io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io.write_png saves RGB image when given greyscale tensor
4 participants
@andfoy @fmassa @datumbox @facebook-github-bot