Skip to content

Fix redirect behavior of datasets.utils.download_url (#3564) #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix redirect behavior of datasets.utils.download_url (#3564) #3566

merged 1 commit into from
Mar 15, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 15, 2021

  • use head request for redirects

  • remove requests dependency

@pmeier
Fix redirect behavior of datasets.utils.download_url (pytorch#3564)
66e43f6 
* use head request for redirects

* remove requests dependency
@pmeier pmeier requested a review from fmassa March 15, 2021 11:26
fmassa
fmassa approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @seemethere for visibility

@codecov
Copy link

codecov bot commented Mar 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/0.9@0dbc7d8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/0.9    #3566   +/-   ##
==============================================
  Coverage               ?   75.88%           
==============================================
  Files                  ?      105           
  Lines                  ?     9727           
  Branches               ?     1561           
==============================================
  Hits                   ?     7381           
  Misses                 ?     1858           
  Partials               ?      488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbc7d8...66e43f6. Read the comment docs.

@fmassa fmassa merged commit 2d9dcb9 into pytorch:release/0.9 Mar 15, 2021
@pmeier pmeier deleted the fix-redirect-url branch March 15, 2021 12:34
@fmassa fmassa mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @fmassa @facebook-github-bot