Only sync cuda if cuda available #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat00155
approved these changes
Apr 15, 2021
|
Thanks @NicolasHug, looks good to me. |
datumbox
approved these changes
Apr 17, 2021
There was a problem hiding this comment.
LGTM, thanks!
@NicolasHug I changed the tag from fix to bug because from an earlier discussion with @fmassa we said to use the same tag for marking Issues and PRs. Can't find it at the moment to link it. If there is a change on that let me know.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Reviewed By: NicolasHug Differential Revision: D28169155 fbshipit-source-id: 16236971b990960ca4df92f4d82c0713c5f6a30a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids calling
torch.cuda.synchronize()if cuda is not available on the machine. This is to address #1204 (comment)