[FBcode->GH] Fix torchvision_functional_tensor test_rgb2hsv #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The test is constantly failing: https://www.internalfb.com/intern/test/562949982577806?ref_report_id=0 The fix just adjusts `atol` from 1e-8 to 1e-7. The equality test was likely failing on exact zeros Reviewed By: fmassa Differential Revision: D27790959 fbshipit-source-id: ed6fa7052b4f1cacc0dcbbbfd70d3554c05d02d9
|
This pull request was exported from Phabricator. Differential Revision: D27790959 |
NicolasHug
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
Summary: Pull Request resolved: #3676 The test is constantly failing: https://www.internalfb.com/intern/test/562949982577806?ref_report_id=0 The fix just adjusts `atol` from 1e-8 to 1e-7. The equality test was likely failing on exact zeros Reviewed By: fmassa Differential Revision: D27790959 fbshipit-source-id: 58d06250df5905e39e197ee946ee2d875a5bab76
prabhat00155
approved these changes
Apr 15, 2021
|
Closing for the same reasons as #3675. If you intended to send a PR against master please reopen and change target branch. |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Apr 19, 2021
Summary: Pull Request resolved: pytorch#3676 The test is constantly failing: https://www.internalfb.com/intern/test/562949982577806?ref_report_id=0 The fix just adjusts `atol` from 1e-8 to 1e-7. The equality test was likely failing on exact zeros Reviewed By: fmassa Differential Revision: D27790959 fbshipit-source-id: 58d06250df5905e39e197ee946ee2d875a5bab76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The test is constantly failing: https://www.internalfb.com/intern/test/562949982577806?ref_report_id=0
The fix just adjusts
atolfrom 1e-8 to 1e-7.The equality test was likely failing on exact zeros
Reviewed By: fmassa
Differential Revision: D27790959