fix check for exceeded quota on Google Drive #3710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmeier sorry, I don't have lots of context around this specific fix. Is there a specific reason you prefer me to review it? |
|
@datumbox Yeah sorry, didn't really pay attention that you only labeled the issue. |
NicolasHug
reviewed
Apr 23, 2021
NicolasHug
approved these changes
Apr 23, 2021
fmassa
approved these changes
Apr 23, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Summary: * fix check for exceeded quota on Google Drive * safeguard quota exceed check Reviewed By: NicolasHug Differential Revision: D28169136 fbshipit-source-id: dc305a87e5936e142d1b9c73520f6b4f2e7764cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3708. If possible lets accept this for now without tests. I need to find a way to emulate this situation in the test suite.