Remove TransformsTester #3946
Merged
Remove TransformsTester #3946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
added
code quality
module: tests
module: transforms
and removed
cla signed
labels
|
Failure looks like an unrelated timeout |
prabhat00155
reviewed
Jun 2, 2021
prabhat00155
approved these changes
Jun 2, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
Reviewed By: NicolasHug Differential Revision: D29027343 fbshipit-source-id: 2cdf5873ca280043121b3f75d160ae15f16b0ede
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
TransformsTesterclass and turns its methods into function. The diff looks big but it's 99% just dumb renaming.This will greatly ease the porting of the tests in
test_functional_tensor.pyandtest_transforms_tensor.pyand avoid conflicts.