Skip to content

port adjusts in test_transforms to pytest #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2021
Merged

port adjusts in test_transforms to pytest #3950

merged 2 commits into from
Jun 3, 2021

Conversation

saswatpp
Copy link
Contributor

@saswatpp saswatpp commented Jun 3, 2021

Refactor Group P as mentioned in #3945

  • test_adjust_brightness
  • test_adjust_contrast
  • test_adjust_gamma
  • test_adjust_hue
  • test_adjust_saturation
  • test_adjust_sharpness
  • test_adjusts_L_mode

@facebook-github-bot
Copy link
Contributor

Hi @saswatpp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@datumbox datumbox requested a review from NicolasHug June 3, 2021 08:35
NicolasHug
NicolasHug approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was smooth!
thanks a lot @saswatpp !

@NicolasHug NicolasHug merged commit 4c0fdc6 into pytorch:master Jun 3, 2021
@NicolasHug NicolasHug mentioned this pull request Jun 3, 2021
Closed
16 tasks
facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2021
@fmassa @facebook-github-bot
[fbsync] Port test_adjust_xxx in test_transforms to pytest (#3950)
2f5df05 
Reviewed By: NicolasHug

Differential Revision: D29027319

fbshipit-source-id: 3514b32c03e35c3882d7bfd8027eec6dfc1d0d5e
@saswatpp saswatpp mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saswatpp @facebook-github-bot @NicolasHug @datumbox