Port Group O test to pytest ref #3945 #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Thanks @ShrillShrestha ! This looks great, I made some minor comment, LMK what you think
test/test_transforms.py
Outdated
| assert_equal(padded_img.size, [edge_size + 2 * pad for edge_size in img.size], check_stride=False) | ||
|
|
||
|
|
||
| def _test_randomness(fn, trans, configs): |
There was a problem hiding this comment.
This is fine as-is for me. If we want, we can go one step further about parametrization here. I'm thinking of somthing like this:
@pytest.mark.skipif(stats is None, reason="scipy.stats not available")
@pytest.mark.parametrize('fn, trans, conf', [
(F.invert, transforms.RandomInvert, {}),
(F.posterize, transforms.RandomPosterize, {"bits": 4}),
...
])
@pytest.mark.parametrize('p', (.5, .7))
def test_randomness(fn, trans, conf, p):and we could get rid of all the other functions and the 2 for loops inside. WDYT?
Again this is optional: feel free to leave as-is if you prefer ;)
There was a problem hiding this comment.
Yeah, I think, we can parametrize it. I have made the changes.
Nice! Thanks a lot @ShrillShrestha ! |
16 tasks
|
@NicolasHug, thanks for guiding me. :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
Reviewed By: NicolasHug Differential Revision: D29027333 fbshipit-source-id: e9a6e49df429c8c0f5604bcf0963fb43907767a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Group O mentioned in #3945
Please let me know if I need to change anything.