port tests in test_transforms to pytest #3957
Conversation
|
Hi @sahilg06! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
sahilg06
changed the title
There was a problem hiding this comment.
Thanks @sahilg06 , this looks great!
LGTM, I re-started the CI and I'll merge when green
| img = F.to_pil_image(np.ones((100, 100, 3), dtype=np.uint8) * 255, "RGB") | ||
|
|
||
| num_bands = len(mode) | ||
| wrong_num_bands = num_bands + 1 |
There was a problem hiding this comment.
This is totally fine as is but just a side note: it's usually good practice to declare a variable in the region where it's used. so in this case we could have declared this one below right before (or within) the with pytest.raises block. It's really a nitpick, no need to change anything!
|
All green except for ci/circleci: binary_win_conda_py3.9_cu111 which will probably timeout (again). It's unrelated so I'll merge. Thanks again @sahilg06 ! |
Reviewed By: NicolasHug Differential Revision: D29027348 fbshipit-source-id: 3aad7d42d36c851b120d009b2724a68524166be7
Refactor Group K mentioned in #3945