Port Group A test_transforms.py to pytest #3959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqwang
commented
Jun 3, 2021
zhiqwang
commented
Jun 3, 2021
zhiqwang
commented
Jun 3, 2021
NicolasHug
reviewed
Jun 4, 2021
There was a problem hiding this comment.
Thanks a lot @zhiqwang this looks good!
Perhaps we can take advantage of the parametrization over tuples to avoid a bit of the if/else blocks. I commented below, let me know what you think!
16 tasks
NicolasHug
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Thanks a lot @zhiqwang ! Some last minor comment but LGTM when addressed !
NicolasHug
reviewed
Jun 5, 2021
|
Thanks a lot @zhiqwang !! |
|
@NicolasHug Also thanks for your guidances here! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
…est (#3959) Reviewed By: NicolasHug Differential Revision: D29027353 fbshipit-source-id: c165f7cffebf36f0f56277c5a1f0c3a043189ea3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To port Group A in test_transforms.py to pytest as discussed in #3945
cc @NicolasHug