Port test_models to pytest #3978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnirudhDagar
commented
Jun 6, 2021
NicolasHug
reviewed
Jun 6, 2021
There was a problem hiding this comment.
Thanks @AnirudhDagar , I made a few comments but this looks good!
|
@NicolasHug thanks for the feedback and detailed review as always. I've incorporated the suggested changes :) |
NicolasHug
approved these changes
Jun 7, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
Reviewed By: NicolasHug Differential Revision: D29027312 fbshipit-source-id: 6aff95c5e19369ea6a4f143c6cd507621bcb100c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts tests for the models utilizing
pytestin order to get rid ofunittest. More details at #3951.