Finish porting test_functional_tensor.py to pytest #3990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
added
code quality
module: tests
module: transforms
and removed
cla signed
labels
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Reviewed By: fmassa Differential Revision: D29097710 fbshipit-source-id: e8e6226f032c5d5bf4dd999a34944071318c6985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one test left:
test_scale_channel.I also removed a test that was already ported (there was some merging issue in another PR that put it back, and I missed it in the review)
After that the entire file is fully pytest-compliant!