Import hipify_python only when needed #4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this after the version check to avoid failures on import for earlier torch where that module did not exist. See pytorch#3901
datumbox
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
I don't see why not. Thanks for the improvement @Flamefire. Will merge after green tests.
|
The failing test on binary_linux_conda_py3.8_cu111 in unrelated. Merging. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Summary: Do this after the version check to avoid failures on import for earlier torch where that module did not exist. See #3901 Reviewed By: fmassa Differential Revision: D29097727 fbshipit-source-id: 492ec606b033a7761dae4649ae638e6dc485d5c7 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this after the version check to avoid failures on import for earlier torch where that module did not exist.
See #3901