Port tests in test_transforms_video.py to pytest #4040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevPranjal
commented
Jun 10, 2021
test/test_transforms_video.py
Outdated
| msg = "height: " + str(height) + " width: " \ | ||
| + str(width) + " oheight: " + str(oheight) + " owidth: " + str(owidth) | ||
| self.assertEqual(sum1.item() > 1, True, msg) | ||
| assert sum1.item() > 1 == True, msg |
There was a problem hiding this comment.
flake test here suggests:
./test/test_transforms_video.py:85:32: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Do I need to change or stick with the original implementation?
There was a problem hiding this comment.
Yes we should just use assert sum1.item() > 1, msg :)
DevPranjal
force-pushed
the
refactor-test_transforms_video
branch
from
8ed0529 to
5006659
Compare
|
Thanks @DevPranjal !! |
8 tasks
|
Thanks for the fix. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Reviewed By: fmassa Differential Revision: D29097720 fbshipit-source-id: fe2afb61e2a5ea23f467793dd33f545435d4db26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test_transforms_video.py to pytest as mentioned in #4033