Skip to content

Handle grayscale images on draw_bounding_boxes #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2021
Merged

Handle grayscale images on draw_bounding_boxes #4043

merged 4 commits into from
Jun 11, 2021

Conversation

sugatoray
Copy link
Contributor

Refer to #4042.

sugatoray added 2 commits June 10, 2021 13:03
@sugatoray
allow single-channel-images in draw_bounding_boxes
97226fe 
This is bug-fix for issue #4042.

#4042
@sugatoray
Merge pull request #1 from sugatoray/sugatoray-patch-1
417acfd 
allow single-channel-images in draw_bounding_boxes
@facebook-github-bot
Copy link
Contributor

Hi @sugatoray!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

datumbox
datumbox approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 552a406 into pytorch:master Jun 11, 2021
NicolasHug
NicolasHug reviewed Jun 11, 2021
View reviewed changes
torchvision/utils.py

ndarr = image.permute(1, 2, 0).numpy()
# allow single-channel-images
# shape: (1, H, W) with C = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the shape (H, W, C) instead, since we permuted the dimensions in the line above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I realized the comment is not correct (only after the checks started running): it should be worded as below to avoid any confusion.

# image tensor shape: (1, H, W) with C = 1
# ndarr.shape: (H, W, C)

@NicolasHug
Copy link
Member

Thanks for the PR @sugatoray !
I think it's correct but there might be an issue with the comment.
Also, ideally, such improvements/fixes should come with a simple non-regression test.

Would you mind following-up with a PR that fixes the comment and that adds a simple test in test_utils.py that makes sure 1-channel images are supported?

@datumbox
Copy link
Contributor

@NicolasHug To fix the bug and to avoid back and forth, I merged and then issued a follow up here #4049

@datumbox datumbox changed the title bug-fix to issue #4042 Handle grayscale images on draw_bounding_boxes Jun 11, 2021
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
@NicolasHug @facebook-github-bot
[fbsync] bug-fix to issue #4042 (#4043)
cbe47c8 
Summary:
* allow single-channel-images in draw_bounding_boxes

This is bug-fix for issue #4042.

#4042

* change made for passing linting requirements

#4042

Reviewed By: fmassa

Differential Revision: D29097731

fbshipit-source-id: 0a6a2a2cb3cf030fceadafff583fa4209aa9d3d9
@sugatoray
Copy link
Contributor Author

@NicolasHug Checking back now I see that you had left a comment on adding a test. I know someone else (either you or @datumbox) had been kind enough to write it up and push the PR for merger. Thank you for that. I will make sure to add tests in future PRs (I will submit another bugfix soon).

@datumbox
Copy link
Contributor

@sugatoray You are welcome. I have added a unit-test but you are welcome to send more PRs on the future. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug left review comments

+1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug cla signed module: utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sugatoray @facebook-github-bot @NicolasHug @datumbox