Skip to content

Fix current CI failures #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix current CI failures #4121

merged 1 commit into from
Jun 25, 2021

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jun 25, 2021 •
edited
Loading

Closes #4120

This is just temporary, hopefully they'll just raise a ValueError instead of a custom exception

pmeier
pmeier approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a temporary fix. I'll discuss this with the team to see how we handle such a case. Thanks for bringing it up!

@NicolasHug NicolasHug merged commit d9633fc into pytorch:master Jun 25, 2021
facebook-github-bot pushed a commit that referenced this pull request Jun 28, 2021
@NicolasHug @facebook-github-bot
[fbsync] Fix failing tests by catching the proper exception from torc…
7f069a3 
…h.testing (#4121)

Reviewed By: fmassa

Differential Revision: D29395324

fbshipit-source-id: 6b297f9783330e0738dfcea3625108852174237b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
bug cla signed module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failures everywhere
3 participants
@NicolasHug @pmeier @facebook-github-bot