Do not install lame when building torchvision #4162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed only for ffmpeg integration, which is disabled anyway
seemethere
approved these changes
Jul 9, 2021
To update pkg_resources.packaging to version 20.0+
|
Hey @malfet! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
Summary: * Do not install lame when building torchvision It is needed only for ffmpeg integration, which is disabled anyway * Also upgrade setuptool To update pkg_resources.packaging to version 20.0+ Reviewed By: fmassa Differential Revision: D29659496 fbshipit-source-id: a3bbe76029c68d2cd521b9d360e0825873455448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is needed only for ffmpeg integration, which is disabled anyway.
Also update setuptools to workaround:
Introduced by pytorch/pytorch#59665 and attempted to be mitigated by pytorch/pytorch#61053