Catch ValueError due to recent change to torch.testing.assert_close #4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Jul 12, 2021
|
Thanks for the reviews, I'll look into the rest of the (unrelated) failures in a separate PR |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
…t_close (#4165) Reviewed By: fmassa Differential Revision: D29659491 fbshipit-source-id: 59858bc5312105999fc2060d090c657b5021ebf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pytorch/pytorch#61031 now merged, we should catch
ValueErrors.This should fix most of the currently failing tests.
CC @pmeier :) !