[FBcode->GH] [JIT] Add reference semantics to TorchScript classes (#44324) #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch/pytorch#44324 **Summary** This commit adds reference semantics to TorchScript class types; modifications made to them within TorchScript will be visible in Python. **Test Plan** This commit adds a unit test to `TestClassType` that checks that modifications made to a class type instance passed into TorchScript are visible in Python after executing the scripted function or module. **Fixes** This commit closes #41421. Test Plan: Imported from OSS Reviewed By: gmagogsfm Differential Revision: D24912807 Pulled By: SplitInfinity fbshipit-source-id: d64ac6211012425b040b987e3358253016e84ca0
|
This fixes the currently failing |
fmassa
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of c4e1e9e