Skip to content

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Jul 12, 2021

Following up on #2025, this PR adds missing typing annotations in datasets/coco.py.

Any feedback is welcome!

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @frgfm!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm

@NicolasHug NicolasHug merged commit 835c2c3 into pytorch:master Jul 16, 2021
@frgfm frgfm deleted the coco-typing branch July 19, 2021 08:04
facebook-github-bot pushed a commit that referenced this pull request Jul 27, 2021
Reviewed By: fmassa

Differential Revision: D29932704

fbshipit-source-id: 622eda598686197fa1c76dd9bafff57fa2c08f46
@frgfm frgfm mentioned this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants