Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 20, 2021

Closes #4194.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , LGTM, feel free to self merge. We can always adjust in the future, should we want to

pytest.ini Outdated
# show summary of all tests that did not pass
-ra
# Make tracebacks shorter
--tb=short
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytorch uses native. I'm not too familiar with it, do you have a preference?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends. native might get better tracebacks for non-python errors. short is even more concise for default Python tracebacks. No strong opinion.

@pmeier pmeier merged commit 1dd5d1f into pytorch:master Jul 20, 2021
@pmeier pmeier deleted the pytest-config branch July 20, 2021 17:08
facebook-github-bot pushed a commit that referenced this pull request Jul 27, 2021
Summary:
* add `pytest.ini`

* use native traceback

Reviewed By: fmassa

Differential Revision: D29932703

fbshipit-source-id: 7fb1aa74cf8fb382e93f62f91bd8b8b78e3d2660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pytest.ini
3 participants