Import squeeze from symbolic_opset11 #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jul 30, 2021
| from torch.onnx.symbolic_helper import parse_args, scalar_type_to_onnx, scalar_type_to_pytorch_type, \ | ||
| cast_pytorch_to_onnx | ||
| from torch.onnx.symbolic_opset9 import select, unsqueeze, squeeze, _cast_Long, reshape | ||
| from torch.onnx.symbolic_opset9 import _cast_Long |
There was a problem hiding this comment.
Thanks for the PR @jiafatom , I'm wondering, why leaving this one to opset9?
There was a problem hiding this comment.
There is no _cast_Long in torch.onnx.symbolic_opset11. Not every function can be found in upper opsets torch.onnx.symbolic_opset11. We only updated if there is spec change.
There was a problem hiding this comment.
@NicolasHug Can we merge the PR? thanks!
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Reviewed By: NicolasHug Differential Revision: D30417189 fbshipit-source-id: ca50850c51d083cd0e9e4b8c93abfba10d4af7bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_register_custom_opset_onnx_opset_version=11, so we need importsqueeze, etc fromsymbolic_opset11.