Skip to content

Conversation

NicolasHug
Copy link
Member

I missed this during the reviews, we should use with pytest.raises(TypeError): on every individual line

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit db530d8 into pytorch:master Aug 16, 2021
@NicolasHug
Copy link
Member Author

CI failures are due to #4278 and are unrelated.

Thanks for the review, I'll merge!

facebook-github-bot pushed a commit that referenced this pull request Aug 20, 2021
Reviewed By: NicolasHug

Differential Revision: D30417200

fbshipit-source-id: d57f0e6387ae51a22534850e57a628004d7db942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants