Skip to content

Avoided string comparisons for PyTorch version comparison #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 11, 2021
Merged

Avoided string comparisons for PyTorch version comparison #4307

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef07506
Updated setup.py to use TorchVersion object for version comparision
ABD-01 Aug 23, 2021
7e0e093
Merge branch 'pytorch:main' into version_compare
ABD-01 Aug 23, 2021
8c19310
Merge branch 'main' into version_compare
ABD-01 Aug 27, 2021
0c8670b
Merge branch 'main' into version_compare
ABD-01 Sep 2, 2021
306ba55
Merge branch 'main' into version_compare
ABD-01 Sep 10, 2021
fab43cd
Merge branch 'main' into version_compare
ABD-01 Sep 13, 2021
9b3e641
Merge branch 'main' into version_compare
ABD-01 Sep 18, 2021
825a2ac
Merge branch 'main' into version_compare
ABD-01 Oct 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,8 @@ def get_extensions():
)

is_rocm_pytorch = False
TORCH_MAJOR = int(torch.__version__.split(".")[0])
TORCH_MINOR = int(torch.__version__.split(".")[1])
if TORCH_MAJOR > 1 or (TORCH_MAJOR == 1 and TORCH_MINOR >= 5):

if torch.__version__ >= "1.5":
from torch.utils.cpp_extension import ROCM_HOME

is_rocm_pytorch = True if ((torch.version.hip is not None) and (ROCM_HOME is not None)) else False
Expand Down