[FBcode->GH] Port quantize_val and dequantize_val into torchvision to avoid at::native and android xplat incompatibility #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive and android xplat incompatibility Summary: This diff ports `quantize_val` and `dequantize_val` from at::native to torchvision because native kernels are incompatible with android xplat builds (see D30234056). This should only be temporary until we find a way to move those functions out of at::native, or until the at::native / android incompatibility disappears. Reviewed By: fmassa Differential Revision: D30393619 fbshipit-source-id: 18b7b1b349ad9a24088a120e23da7535f7fa7ddc
|
This PR is a sync from FBcode. I suggest merging it even if it breaks master due to clang formatting issues and fix ASAP on a follow up PR. This will simplify the process of syncing the change back to FBcode later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff ports
quantize_valanddequantize_valfrom at::native to torchvision because native kernels are incompatible with android xplat builds (see D30234056).This should only be temporary until we find a way to move those functions out of at::native, or until the at::native / android incompatibility disappears.
Reviewed By: fmassa
Differential Revision: D30393619
fbshipit-source-id: 18b7b1b349ad9a24088a120e23da7535f7fa7ddc