Jpeg unpin - Cherrypicking #4288 #4344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat00155
approved these changes
Sep 1, 2021
| // For libjpeg version <= 9b, the out_size parameter in jpeg_mem_dest() is | ||
| // defined as unsigned long, where as in later version, it is defined as size_t. | ||
| // For windows backward compatibility, we define JpegSizeType as different types | ||
| // according to the libjpeg version used, in order to prevent compilcation |
| // according to the libjpeg version used, in order to prevent compilcation | ||
| // errors. | ||
| #if defined(_WIN32) || !defined(JPEG_LIB_VERSION_MAJOR) || \ | ||
| (JPEG_LIB_VERSION_MAJOR < 9) || \ |
There was a problem hiding this comment.
Why () around single condition?
|
Thanks for the quick review @prabhat00155. Definitely agree with your review comments. Note that this is a cherrypick from a different PR that landed on main branch that we try to bring on v0.10.1. Do you think it would be best to make this changes on a separate PR against main branch? |
Makes sense, I can do that, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4181 on 0.10