Skip to content

Resolving tracing problem on StochasticDepth iterator #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2021
Merged

Resolving tracing problem on StochasticDepth iterator #4372

merged 2 commits into from
Sep 6, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Sep 6, 2021

Fixing issue reported at #4302 (comment)

@datumbox datumbox requested a review from fmassa September 6, 2021 14:17
fmassa
fmassa approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa mentioned this pull request Sep 6, 2021
Merged
3 tasks
@fmassa fmassa merged commit 5fb36a1 into pytorch:main Sep 6, 2021
@datumbox datumbox deleted the bugs/tracing_stochasticdepth branch September 6, 2021 14:53
@alexander-soare
Copy link
Contributor

@datumbox I think the next line now raises an error:

TypeError: empty() received an invalid combination of arguments - got (Proxy, device=Attribute, dtype=Attribute), but expected one of:
 * (tuple of ints size, *, tuple of names names, torch.memory_format memory_format, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)
 * (tuple of ints size, *, torch.memory_format memory_format, Tensor out, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)

Noticed as I was trying to re-enable StochasticDepth in fx feature extraction tests.

@fmassa
Copy link
Member

fmassa commented Sep 6, 2021 •
edited
Loading

@alexander-soare I'm fixing this now, PR in #4373

@fmassa fmassa mentioned this pull request Sep 6, 2021
Merged
facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2021
@datumbox @facebook-github-bot
[fbsync] Resolving tracing problem on StochasticDepth iterator. (#4372)
c23c2c4 
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: fmassa

Differential Revision: D30793342

fbshipit-source-id: 02f4181eab0cd0b271c639e002860771e52564fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
bug module: ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datumbox @alexander-soare @fmassa @facebook-github-bot