Skip to content

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 5, 2018

  • Update .travis.yml to test also on Pillow-SIMD
  • Fix bug in F.affine with function signature difference between Pillow 4.3 vs 5.0

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python changes LGTM. I'm not familiar with travis but the changes look good. But I'd rather someone else have another look at the .travis.yml changes.

.travis.yml Outdated
- pip install --upgrade pytest

- if [[ "$IMAGE_BACKEND" == "Pillow-SIMD" ]]; then
pip uninstall -y pillow && CC="cc -mavx2" pip install --force-reinstall pillow-simd;

This comment was marked as off-topic.

This comment was marked as off-topic.

@vfdev-5 vfdev-5 force-pushed the tests_with_pillow_simd branch from 0b3f941 to e0984c1 Compare March 27, 2018 14:00
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Mar 27, 2018

As suggested, changed -mavx2 to -mnative. Added missing RandomAffine in docs.

@fmassa
Copy link
Member

fmassa commented Mar 27, 2018

@vfdev-5 it seems that one of the builds failed during compilation of Pillow-SIMD, could you have a look?

@vfdev-5 vfdev-5 force-pushed the tests_with_pillow_simd branch from e0984c1 to a29faf5 Compare March 27, 2018 15:28
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Mar 27, 2018

@fmassa fixed with -march=native

@fmassa fmassa merged commit ca5d4db into pytorch:master Mar 27, 2018
@fmassa
Copy link
Member

fmassa commented Mar 27, 2018

Thansks!

@vfdev-5 vfdev-5 deleted the tests_with_pillow_simd branch March 27, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants