Skip to content

Conversation

freud14
Copy link
Contributor

@freud14 freud14 commented Mar 7, 2018

Hi,

I split up the ImageFolder class to create a DatasetFolder class so that any dataset split in folders can be loaded. I also added unit tests for ImageFolder.

Thank you.

@soumith soumith merged commit ab03dc4 into pytorch:master Mar 9, 2018
@soumith
Copy link
Member

soumith commented Mar 9, 2018

lgtm, thanks @freud14 !

soumith added a commit that referenced this pull request Mar 9, 2018
soumith added a commit that referenced this pull request Mar 9, 2018
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 14, 2018

@freud14 I wonder whether it is necessary to upload images a*.png and b*.png. Correct me if wrong, but it seems to me that the content of images is not compared in the tests. If it is the case, the test script can simply create files in a temp folder, run tests and clean up.

@fmassa
Copy link
Member

fmassa commented Mar 14, 2018

@vfdev-5 I don't think it's necessary to have several similar images for testing, only one or two would suffice I think. But there is no harm in keeping them now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants