add torchdata as prototype dependency #4499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by meta-pytorch/data#20. |
pmeier
commented
Sep 30, 2021
| @@ -1,3 +1,13 @@ | |||
| try: | |||
| import torchdata | |||
| except (ModuleNotFoundError, TypeError) as error: | |||
There was a problem hiding this comment.
The torchdata library hosted on PyPI fails for me at import with an TypeError. This is why we can aggregate both failure cases here.
There was a problem hiding this comment.
Chatted with @pmeier , this is a bug in the torchdata from PyPI (which is unrelated to the torchdata we are depending on.
There was a problem hiding this comment.
If you do pip install torchdata, python -c "import torchdata" fails with
TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases
fmassa
reviewed
Sep 30, 2021
fmassa
approved these changes
Sep 30, 2021
| @@ -1,3 +1,13 @@ | |||
| try: | |||
| import torchdata | |||
| except (ModuleNotFoundError, TypeError) as error: | |||
There was a problem hiding this comment.
Chatted with @pmeier , this is a bug in the torchdata from PyPI (which is unrelated to the torchdata we are depending on.
|
Hey @fmassa! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
Summary: * add torchdata as prototype dependency * ignore torchdata for mypy * move git dependency out of conda environment file * try unsetting PYTORCH_VERSION env var * cleanup * move installation of torchdata after installtion of PyTorch * regenerate circlci config * remove branch from torchdata download link Reviewed By: prabhat00155, NicolasHug Differential Revision: D31309548 fbshipit-source-id: 40c9745ae4cd8a469f70e62c1ebaa88e78d21e70 Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* add torchdata as prototype dependency * ignore torchdata for mypy * move git dependency out of conda environment file * try unsetting PYTORCH_VERSION env var * cleanup * move installation of torchdata after installtion of PyTorch * regenerate circlci config * remove branch from torchdata download link Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* add torchdata as prototype dependency * ignore torchdata for mypy * move git dependency out of conda environment file * try unsetting PYTORCH_VERSION env var * cleanup * move installation of torchdata after installtion of PyTorch * regenerate circlci config * remove branch from torchdata download link Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @pmeier @mthrok @bjuncek