Skip to content

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Oct 1, 2021

Prototype features are not present in the release binaries

@fmassa fmassa requested review from datumbox and pmeier October 1, 2021 12:02
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the future we should probably find a mechanism to exclude the folder by setting some environment variable. I know @mthrok had some ideas about this, but I can't find the comment.

@fmassa
Copy link
Member Author

fmassa commented Oct 1, 2021

Yes. IIRC @mthrok hasn't implemented this feature (only had the proposal for implementing it), so for now manually removing it is the recommended way IIRC

@mthrok
Copy link
Contributor

mthrok commented Oct 1, 2021

Yes. IIRC @mthrok hasn't implemented this feature (only had the proposal for implementing it), so for now manually removing it is the recommended way IIRC

Yup, that's the case.

@fmassa fmassa merged commit 8c9b48d into pytorch:release/0.11 Oct 1, 2021
@fmassa fmassa deleted the remote-prototype-release branch October 1, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants