Skip to content

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Oct 6, 2021

Partly addresses #4509.

The changes follow this example.

cc @datumbox

@prabhat00155
Copy link
Contributor Author

prabhat00155 commented Oct 6, 2021

Training logs without any changes:
amp_no_changes_training_logs.txt
Training logs with changes:
amp_changes_training_log1.txt
amp_changes_training_log2.txt

Note: While running the above training jobs, I had not yet changed apex argument.

Following log files with and without --amp argument passed during training.
training_with_amp.txt
training_without_amt.txt

@prabhat00155 prabhat00155 marked this pull request as ready for review October 6, 2021 18:01
@NicolasHug
Copy link
Member

looks like there are linting issue (black formatting), LMK if you need any help regarding this

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Feel free to merge after fixing the linter issues.

@prabhat00155
Copy link
Contributor Author

looks like there are linting issue (black formatting), LMK if you need any help regarding this

Thanks @NicolasHug, I foolishly ran ufmt format torchvision when my changes were under references.

@prabhat00155 prabhat00155 merged commit 403bded into pytorch:main Oct 7, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/replace_apex_amp branch October 7, 2021 11:40
facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2021
#4547)

Summary:
* Updated classification reference script to use torch.cuda.amp

* Assigned scaler to None if amp is False

* Fixed linter errors

Reviewed By: NicolasHug

Differential Revision: D31505567

fbshipit-source-id: cbddc5de9b9cc48beb09c56d60f54645ba655813
mszhanyi pushed a commit to mszhanyi/vision that referenced this pull request Oct 19, 2021
…h#4547)

* Updated classification reference script to use torch.cuda.amp

* Assigned scaler to None if amp is False

* Fixed linter errors
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
…h#4547)

* Updated classification reference script to use torch.cuda.amp

* Assigned scaler to None if amp is False

* Fixed linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants