fix Caltech datasets #4556
Merged
fix Caltech datasets #4556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 7, 2021
Comment on lines
+185
to
+191
| n = len( | ||
| [ | ||
| item | ||
| for item in os.listdir(os.path.join(self.root, "256_ObjectCategories", c)) | ||
| if item.endswith(".jpg") | ||
| ] | ||
| ) |
There was a problem hiding this comment.
The folders contain one rogue folder as well as one rogue file. Just going by the number of items in the folder and assuming everything is an image, will result in an error if we iterate over the complete dataset.
| download_and_extract_archive( | ||
| "http://www.vision.caltech.edu/Image_Datasets/Caltech101/Annotations.tar", | ||
| self.root, | ||
| filename="101_Annotations.tar", |
There was a problem hiding this comment.
For some (probably unintended) reason, we renamed this file instead of leaving it as is.
prabhat00155
approved these changes
Oct 7, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Summary: Co-authored-by: Prabhat Roy <prabhatroy@fb.com> Reviewed By: NicolasHug Differential Revision: D31505552 fbshipit-source-id: 1903c12ab14e3b87e82c4b926fed7e5455f9cd27
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one bug and one inconsistency in the
Caltech(101|256)datasets. See inline comments for details.cc @pmeier