Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 7, 2021

Apart from being easier to maintain, this also makes it easier to mock for dataset tests / benchmarks.

cc @pmeier

Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier, looks good to me.

@prabhat00155 prabhat00155 merged commit 05dcf50 into pytorch:main Oct 7, 2021
@pmeier pmeier deleted the fix-celeba branch October 7, 2021 12:57
facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2021
Summary: Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

Reviewed By: NicolasHug

Differential Revision: D31505568

fbshipit-source-id: 2bff0f65f267233f246e101f1a153be7b41b54a5
mszhanyi pushed a commit to mszhanyi/vision that referenced this pull request Oct 19, 2021
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants