simplify QMNIST download logic #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat00155
approved these changes
Oct 7, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Reviewed By: NicolasHug Differential Revision: D31505559 fbshipit-source-id: 7c9c11420d9da0a9e4cec1bd8364c6d13fa65bc7
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download_and_extract_archivedoes all of the handling that is put in there manually. Letting it do its job, makes it easier to mock out the download for testing or benchmarking.cc @pmeier