Skip to content

Pass indexing param to meshgrid to avoid warning #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2021
Merged

Pass indexing param to meshgrid to avoid warning #4645

merged 3 commits into from
Oct 19, 2021
+3 −3

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 18, 2021 •
edited by pytorch-probot bot
Loading

Calling torch.meshgrid starts throwing warnings like

.../torch/functional.py:445: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at  /opt/conda/conda-bld/pytorch_1633849720985/work/aten/src/ATen/native/TensorShape.cpp:2157.)

because of the developments of pytorch/pytorch#50276

This PR explicitly passes indexing="ij" to avoid the warning and preserve the current behaviour (https://pytorch.org/docs/master/generated/torch.meshgrid.html)

cc @datumbox

prabhat00155
prabhat00155 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug!

@NicolasHug NicolasHug merged commit 015eb46 into pytorch:main Oct 19, 2021
mszhanyi pushed a commit to mszhanyi/vision that referenced this pull request Oct 19, 2021
@NicolasHug @mszhanyi
Pass indexing param to meshgrid to avoid warning (pytorch#4645)
35a65c0
facebook-github-bot pushed a commit that referenced this pull request Oct 25, 2021
@fmassa @facebook-github-bot
[fbsync] Pass indexing param to meshgrid to avoid warning (#4645)
08fce7c 
Reviewed By: datumbox

Differential Revision: D31898207

fbshipit-source-id: e23c0b73c6cad555f5247674c214e567eb87ba7f
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@NicolasHug @cyyever
Pass indexing param to meshgrid to avoid warning (pytorch#4645)
58accde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@prabhat00155 prabhat00155 prabhat00155 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @prabhat00155 @facebook-github-bot