Skip to content

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Oct 26, 2021

  • Replace 0.11 docs with the correct 0.11. ones (note the '.'
  • Replace the main ... text in the version and title (what you see when you hover on the tab) with 0.11.0

Related to issue #4574

@facebook-github-bot
Copy link
Contributor

💊 CI failures summary and remediations

As of commit 3f7f495 (more details on the Dr. CI page):


Commit 3f7f495 was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mattip
Copy link
Contributor Author

mattip commented Oct 26, 2021

@brianjo

@brianjo brianjo requested a review from NicolasHug October 26, 2021 17:38
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mattip , just a question below

Related to issue #4574

I think you meant #4754 :)

@@ -9,7 +9,7 @@

<meta name="viewport" content="width=device-width, initial-scale=1.0">

<title>Overview: module code &mdash; Torchvision main documentation</title>
<title>Overview: module code &mdash; Torchvision 0.11.0 documentation</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these types of changes intended? Looks like this file comes from the main branch, so it would be OK to leave main here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are the 0.11.0 release documents. The nightly builds (unstable) should be called main. Also when 0.12 is released, these documents will not change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should all have been part of the build that occurred when the release was tagged, I am not sure why I had to manually correct it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm not sure I understand.

Where can I see the unstable in this PR? I'm only seeing this:

image

Also in the main folder I'm seing this:

image

but it's confusing to see "Torchvision 0.11.0 documentation" when hovering over the tab. Are these intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip I think that some of the edits in your PR might be in the main folder by mistake. (main is our nightly generated docs) I think you meant for your version edits to happen only in the 0.11 folder. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, whoops, sorry. I will fix that.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattip , LGTM. Is it safe to merge despite the apparent CI build issues?

@mattip
Copy link
Contributor Author

mattip commented Oct 27, 2021

Is it safe to merge despite the apparent CI build issues?

I don;t think CI is actually turned on for this branch, there is no config file.
I did check a few things locally, but this is a big change. You may want to download it and look how the html renders in your browser: whether the version selector does what it should.

@vadimkantorov
Copy link

Also, pls fix the not working links to the code pytorch/pytorch#67237

@NicolasHug
Copy link
Member

whether the version selector does what it should

Are you talking about this?

image

It automatically redirects me to https://pytorch.org/vision/versions.html

@mattip
Copy link
Contributor Author

mattip commented Oct 29, 2021

Are you talking about this?

Huh? That should not be showing main (0.12.0a0+9e3fecd), it should be showing 0.11.0 in this PR. Then when you click on it, the versions.html should come up, and link to 0.11 (without the '.').

Also, pls fix the not working links to the code pytorch/pytorch#67237

I think that is a different issue, this PR is about getting the proper 0.11.0 docs into place.

@NicolasHug
Copy link
Member

That should not be showing main (0.12.0a0+9e3fecd), it should be showing 0.11.0 in this PR.

I do see 0.11.0 when looking at file:///Users/nicolashug/dev/vision/0.11/index.html

Then when you click on it, the versions.html should come up, and link to 0.11 (without the '.').

Clicking on it always redirects to https://pytorch.org/vision/versions.html: there's no 0.11 nor 0.11.

@mattip
Copy link
Contributor Author

mattip commented Oct 29, 2021

Clicking on it always redirects to https://pytorch.org/vision/versions.html: there's no 0.11 nor 0.11.

Cool. When you follow that link, it shows a page with 0.11.0 which points to https://pytorch.org/vision/0.11/, so that is all good.

I removed the mistakenly modified "main/*" files.

@NicolasHug
Copy link
Member

Thank you Matti, this makes sense now. Chatting with @brianjo also helped clarify a few things.

This LGTM, it's the WE soon so I'll merge on Monday just to be extra careful :)

@NicolasHug NicolasHug merged commit 18b892c into pytorch:gh-pages Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants