-
Notifications
You must be signed in to change notification settings - Fork 7.2k
rework docs for 0.11.0 release #4755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 3f7f495 (more details on the Dr. CI page): Commit 3f7f495 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main/_modules/index.html
Outdated
@@ -9,7 +9,7 @@ | |||
|
|||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
|
|||
<title>Overview: module code — Torchvision main documentation</title> | |||
<title>Overview: module code — Torchvision 0.11.0 documentation</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these types of changes intended? Looks like this file comes from the main
branch, so it would be OK to leave main
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are the 0.11.0 release documents. The nightly builds (unstable) should be called main
. Also when 0.12 is released, these documents will not change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should all have been part of the build that occurred when the release was tagged, I am not sure why I had to manually correct it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattip I think that some of the edits in your PR might be in the main folder by mistake. (main is our nightly generated docs) I think you meant for your version edits to happen only in the 0.11 folder. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, whoops, sorry. I will fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattip , LGTM. Is it safe to merge despite the apparent CI build issues?
I don;t think CI is actually turned on for this branch, there is no config file. |
Also, pls fix the not working links to the code pytorch/pytorch#67237 |
Are you talking about this? It automatically redirects me to https://pytorch.org/vision/versions.html |
Huh? That should not be showing main (0.12.0a0+9e3fecd), it should be showing 0.11.0 in this PR. Then when you click on it, the versions.html should come up, and link to
I think that is a different issue, this PR is about getting the proper 0.11.0 docs into place. |
I do see 0.11.0 when looking at
Clicking on it always redirects to https://pytorch.org/vision/versions.html: there's no |
Cool. When you follow that link, it shows a page with 0.11.0 which points to https://pytorch.org/vision/0.11/, so that is all good. I removed the mistakenly modified "main/*" files. |
Thank you Matti, this makes sense now. Chatting with @brianjo also helped clarify a few things. This LGTM, it's the WE soon so I'll merge on Monday just to be extra careful :) |
main ...
text in the version and title (what you see when you hover on the tab) with 0.11.0Related to issue #4574