Skip to content

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Oct 27, 2021

Test run:

(pytorch_env) prabhatroy-mbp:scripts prabhatroy$ ./fbcode_to_main_sync.sh prabhat00155/check_dr_ci2 dc1139958404b27e5b1e83ca9bc381462a955e29 master  origin
No local changes to save
Switched to branch 'prabhat00155/check_dr_ci2'
Parsing 2d658180b9343389bb75e7ea9624d7ec1c99c059 Added sync script
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Switched to a new branch 'cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059'
[cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059 7eac1415] Added sync script
 Date: Wed Oct 27 21:07:29 2021 +0100
 1 file changed, 27 insertions(+)
 create mode 100755 scripts/fbcode_to_main_sync1.sh
Enumerating objects: 6, done.
Counting objects: 100% (6/6), done.
Delta compression using up to 16 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 780 bytes | 390.00 KiB/s, done.
Total 4 (delta 1), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: 
remote: Create a pull request for 'cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059' on GitHub by visiting:
remote:      https://github.com/prabhat00155/vision/pull/new/cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059
remote: 
To https://github.com/prabhat00155/vision.git
 * [new branch]        cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059 -> cherrypick_11366_2d658180b9343389bb75e7ea9624d7ec1c99c059
Switched to branch 'prabhat00155/check_dr_ci2'
Parsing 7479640f2912cce4bee3e117264946fa4d35dd27 Removed unused variables from video tests
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Switched to a new branch 'cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27'
[cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27 96b078f1] Removed unused variables from video tests
 Date: Mon Oct 25 17:55:15 2021 +0100
 2 files changed, 22 insertions(+), 28 deletions(-)
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 16 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 692 bytes | 692.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: 
remote: Create a pull request for 'cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27' on GitHub by visiting:
remote:      https://github.com/prabhat00155/vision/pull/new/cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27
remote: 
To https://github.com/prabhat00155/vision.git
 * [new branch]        cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27 -> cherrypick_11366_7479640f2912cce4bee3e117264946fa4d35dd27
Switched to branch 'prabhat00155/check_dr_ci2'
Please review the PRs, add [FBCode->GH] tag on the title and publish them.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 27, 2021

💊 CI failures summary and remediations

As of commit 644edd5 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@prabhat00155 prabhat00155 changed the title [WIP] Added script to sync fbcode changes with main branch Added script to sync fbcode changes with main branch Oct 27, 2021
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , I know this is still wip but I took a brief look, LMK your thoughts.

Do you have plans to extend the script to automatically create the PRs with gh?

@prabhat00155
Copy link
Contributor Author

Thanks @prabhat00155 , I know this is still wip but I took a brief look, LMK your thoughts.

Do you have plans to extend the script to automatically create the PRs with gh?

Thanks @NicolasHug! I tried to keep it similar to import.py, where we manually go and validate the changes before publishing them. We could definitely extend this to automatically create PRs later.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , I made a few more comments below.

Any thought on how we could test this before merging?

@prabhat00155
Copy link
Contributor Author

Thanks @prabhat00155 , I made a few more comments below.

Any thought on how we could test this before merging?

I tested this using a different repo(not fbsyc) to main.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , some last comments but LGTM regardless

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prabhat00155 prabhat00155 merged commit 79b350e into pytorch:main Oct 28, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/fbcode_sync branch October 28, 2021 16:58
@github-actions
Copy link

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@prabhat00155 prabhat00155 added the other if you have no clue or if you will manually handle the PR in the release notes label Oct 28, 2021
facebook-github-bot pushed a commit that referenced this pull request Nov 1, 2021
Summary:
* [WIP] Added script to sync fbcode changes with main branch

* Make unique branches for multiple runs of the script

* Updated the files

* Change echo message

* Addressed review comments

* Removed from_repo command line argument

* Make fork_main_branch optional

Reviewed By: datumbox

Differential Revision: D32064701

fbshipit-source-id: c0d744fa40b48211da12c2eba9e6bd149a23238b
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
* [WIP] Added script to sync fbcode changes with main branch

* Make unique branches for multiple runs of the script

* Updated the files

* Change echo message

* Addressed review comments

* Removed from_repo command line argument

* Make fork_main_branch optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/default cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants