-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Added script to sync fbcode changes with main branch #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added script to sync fbcode changes with main branch #4769
Conversation
💊 CI failures summary and remediationsAs of commit 644edd5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prabhat00155 , I know this is still wip but I took a brief look, LMK your thoughts.
Do you have plans to extend the script to automatically create the PRs with gh
?
Thanks @NicolasHug! I tried to keep it similar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prabhat00155 , I made a few more comments below.
Any thought on how we could test this before merging?
I tested this using a different repo(not fbsyc) to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prabhat00155 , some last comments but LGTM regardless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey @prabhat00155! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * [WIP] Added script to sync fbcode changes with main branch * Make unique branches for multiple runs of the script * Updated the files * Change echo message * Addressed review comments * Removed from_repo command line argument * Make fork_main_branch optional Reviewed By: datumbox Differential Revision: D32064701 fbshipit-source-id: c0d744fa40b48211da12c2eba9e6bd149a23238b
* [WIP] Added script to sync fbcode changes with main branch * Make unique branches for multiple runs of the script * Updated the files * Change echo message * Addressed review comments * Removed from_repo command line argument * Make fork_main_branch optional
Test run: