Fix TORCH_HOME environment variable in docs #4843
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 73351c1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Thanks @stephengmatthews ! This will partially address #4795
One minor suggestion below, but LGTM when adressed. Thanks!
Updated the reference for loading a model to `torch.hub`. Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Thanks @NicolasHug , I hadn't spotted the open issue! I've made the suggested change, too. |
|
Thanks @stephengmatthews , We're unable to merge for now because of the CLA - would you mind taking a look at #4843 (comment) ? I think it can take time to be processed so if you've already done it, nothing more to do on your end :) |
Signed it, so guess it's a waiting game now, thanks again. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Summary: * Fix TORCH_HOME environment variable in docs * Update docs with torch.hub Updated the reference for loading a model to `torch.hub`. Reviewed By: kazhang Differential Revision: D32216697 fbshipit-source-id: 311bda276dca3722cca5e428ab5a5dd53d629146 Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
* Fix TORCH_HOME environment variable in docs * Update docs with torch.hub Updated the reference for loading a model to `torch.hub`. Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Replaced
TORCH_MODEL_ZOO, which is deprecated, withTORCH_HOMEin docs.TORCH_MODEL_ZOOis not used soTORCH_HOMEis the only environment variable to set the cache directory.