-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Update functional_tensor.py #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To resolve issue pytorch#4818 Add assert function and logic after checking bound of image
💊 CI failures summary and remediationsAs of commit f580b5f (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Failures seems related, can you have a look?
Sure, let me see and send again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a couple of comments, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puhuk Thanks it looks great.
Before merging could you also add tests to cover for:
- Corner cases such values right on the threshold
- Ensure that the code fails when an incorrect value is passed
@datumbox, sure let me add test. |
@puhuk You can find similar tests here. I think we need two tests:
|
@datumbox Thanks for sharing! Let me check and send PR |
@datumbox, I'm trying to fix this. Could you give me some time. |
@puhuk Sure thing. Sometimes contributors don't give access to the CircleCi and cant see the errors, so we give a nudge to ensure they are aware. Since you know it and actively work on it, there is no rush. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @puhuk, I think we can simplify the unit-tests a bit. Let me know what you think.
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * Update functional_tensor.py To resolve issue #4818 Add assert function and logic after checking bound of image * Update functional_tensor.py * Update test * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Update test_functional_tensor.py * Fix linter Reviewed By: NicolasHug Differential Revision: D32694295 fbshipit-source-id: c988e438a6a2ddcf272e151161956c21791690c6 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
To resolve issue #4818
Add assert function and logic after checking bound of image.
cc @vfdev-5 @datumbox