Skip to content

Remove unused import os in datasets #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2021
Merged

Remove unused import os in datasets #4879

merged 3 commits into from
Nov 6, 2021

Conversation

kazhang
Copy link
Contributor

@kazhang kazhang commented Nov 5, 2021 •
edited by pytorch-probot bot
Loading

os module is not actually used in these datasets

cc @pmeier

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit ef45f0e (more details on the Dr. CI page):

  • 4/4 failures introduced in this PR

4 failures not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.6_cu111 packaging/build_conda.sh 🔁 rerun
CircleCI binary_libtorchvision_ops_android Build 🔁 rerun
CircleCI binary_linux_conda_py3.7_cu111 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.8_cu111 packaging/build_conda.sh 🔁 rerun

3 jobs timed out:

  • binary_linux_conda_py3.6_cu111
  • binary_linux_conda_py3.7_cu111
  • binary_linux_conda_py3.8_cu111
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kazhang kazhang marked this pull request as ready for review November 6, 2021 04:56
NicolasHug
NicolasHug approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kazhang

@NicolasHug NicolasHug merged commit ec6f12d into pytorch:main Nov 6, 2021
@pmeier
Copy link
Collaborator

pmeier commented Nov 6, 2021

I'm wondering why flake8 hasn't picked up on that. Probably because we also import os.path?

@kazhang kazhang deleted the remove-unused-imports branch November 7, 2021 05:13
facebook-github-bot pushed a commit that referenced this pull request Nov 12, 2021
@kazhang @facebook-github-bot
[fbsync] Remove unused import os in datasets (#4879)
da9cce0 
Summary:
* remove unused imports

* update lsun

Reviewed By: datumbox

Differential Revision: D32298969

fbshipit-source-id: a131da738301043b8c3ad54b3707a5f8e08cb88d
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@kazhang @cyyever
Remove unused import os in datasets (pytorch#4879)
6b5e7f2 
* remove unused imports

* update lsun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazhang @facebook-github-bot @pmeier @NicolasHug