Skip to content

removed lines for Inception v3 and GoogLeNet regarding scipy #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2021
Merged

removed lines for Inception v3 and GoogLeNet regarding scipy #4922

merged 2 commits into from
Nov 12, 2021
+0 −8

Conversation

buckage
Copy link
Contributor

@buckage buckage commented Nov 11, 2021 •
edited by datumbox
Loading

Fixes #4919

@facebook-github-bot
Copy link
Contributor

Hi @buckage!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 11, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit a4cd648 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@oke-aditya
Copy link
Contributor

Rendered docs look correct. Thanks @buckage

https://986476-73328905-gh.circle-artifacts.com/0/docs/models.html#inception-v3

datumbox
datumbox approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 9b034e1 into pytorch:main Nov 12, 2021
@buckage
Copy link
Contributor Author

buckage commented Nov 12, 2021

Thanks!

@buckage buckage deleted the fix-notes-regarding-scipy branch November 12, 2021 15:10
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@buckage @datumbox @cyyever
removed lines for Inception v3 and GoogLeNet regarding scipy (pytorch…
130abc8 
…#4922)

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
@kazhang @facebook-github-bot
[fbsync] removed lines for Inception v3 and GoogLeNet regarding scipy (…
b89e601 
…#4922)

Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: datumbox

Differential Revision: D32470490

fbshipit-source-id: 234343bc6d3d2d95849c3d9fd83e2385aec1800b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the note of needing scipy in GoogleNet and Inception
4 participants
@buckage @facebook-github-bot @oke-aditya @datumbox