Skip to content

Android app switch to pytorch_android stable #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2021
Merged

Android app switch to pytorch_android stable #4926

merged 2 commits into from
Nov 12, 2021
+2 −2

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 12, 2021 •
edited
Loading

This PR does 2 things:

  • Fixes a dependency problem our Android demo app
  • Switches the version to stable to align with the iOS demo app

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 12, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit a18df32 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox changed the title [WIP] Android app switch to pytorch_android stable Android app switch to pytorch_android stable Nov 12, 2021
@datumbox datumbox added the other if you have no clue or if you will manually handle the PR in the release notes label Nov 12, 2021
jdsgomes
jdsgomes approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping

@datumbox datumbox added the bug label Nov 12, 2021
@datumbox datumbox merged commit f676f94 into pytorch:main Nov 12, 2021
@datumbox datumbox deleted the ci/android_app branch November 12, 2021 14:17
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@datumbox @cyyever
Switch Android app to pytorch_android stable. (pytorch#4926)
9369c6f
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
@kazhang @facebook-github-bot
[fbsync] Switch Android app to pytorch_android stable. (#4926)
3b2d7c6 
Reviewed By: datumbox

Differential Revision: D32470486

fbshipit-source-id: 6e89965d16f22eb55633eda801b9f5d92e94fca7
datumbox added a commit that referenced this pull request Dec 8, 2021
@datumbox
Switch Android app to pytorch_android stable. (#4926)
0834968
@datumbox datumbox mentioned this pull request Dec 8, 2021
Merged
datumbox added a commit that referenced this pull request Dec 8, 2021
@datumbox
Fix binary_libtorchvision_ops_android job (#5062)
0cac420 
* Fix `binary_libtorchvision_ops_android` job

Switch pytorchAndroidVersion to non-snapshot

* Switch Android app to pytorch_android stable. (#4926)
@datumbox datumbox mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jdsgomes jdsgomes jdsgomes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug ciflow/default cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @facebook-github-bot @jdsgomes