-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Updates PIL version specifier to prevent issues with padding when image mode = P #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 98c955a (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frgfm, looks good to me.
Hey @prabhat00155! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
…ge mode = P (pytorch#4939) * chore: Updated pillow version specifier * docs: Updated issue ref in comment
@datumbox my bad I didn't know about those, I'll open a PR For the long run, regarding dependency specifier consistency, I had the same on a simpler project. I ended up implementing a python test to parse all of those and notify me when there are issues: https://github.com/frgfm/torch-cam/blob/master/tests/test_requirements.py It supports "requirements.txt" and "setup.py", so it cannot be used as is in this case, but we could try to implement something similar? |
… when image mode = P (#4939) Summary: * chore: Updated pillow version specifier * docs: Updated issue ref in comment Reviewed By: datumbox Differential Revision: D32470471 fbshipit-source-id: 044c3ed78748166f0837fcc5632703c417afd95e
As discussed in #4934, this PR updates the version specifier of PIL to avoid incompatibility of the padding function for specific versions.
Closes #4934
Any feedback is welcome!
cc @oke-aditya