Skip to content

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Nov 16, 2021

As discussed in #4934, this PR updates the version specifier of PIL to avoid incompatibility of the padding function for specific versions.

Closes #4934

Any feedback is welcome!

cc @oke-aditya

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 16, 2021

💊 CI failures summary and remediations

As of commit 98c955a (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_win_conda_py3.9_cu113 (1/1)

Step: "Build conda packages" (full log | diagnosis details | 🔁 rerun)

if errorlevel 1 exit /b 1
 set "CUDNN_SETUP_FILE=C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\cudnn-11.3-windows-x64-v8.2.0.53.zip" 
) 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  5  737M    5 38.9M    0     0  38.9M      0  0:00:18 --:--:--  0:00:18 63.7M
 13  737M   13 96.0M    0     0  96.0M      0  0:00:07  0:00:01  0:00:06 59.0M
 20  737M   20  151M    0     0  75.9M      0  0:00:09  0:00:02  0:00:07 57.2M
 26  737M   26  194M    0     0  64.6M      0  0:00:11  0:00:03  0:00:08 53.7M
 33  737M   33  247M    0     0  61.9M      0  0:00:11  0:00:04  0:00:07 53.4M
 40  737M   40  295M    0     0  59.1M      0  0:00:12  0:00:05  0:00:07 51.0M
 48  737M   48  358M    0     0  59.7M      0  0:00:12  0:00:06  0:00:06 52.5M
 55  737M   55  407M    0     0  58.2M      0  0:00:12  0:00:07  0:00:05 51.5M
 61  737M   61  455M    0     0  56.9M      0  0:00:12  0:00:08  0:00:04 52.2M
 68  737M   68  505M    0     0  56.1M      0  0:00:13  0:00:09  0:00:04 51.8M
 76  737M   76  561M    0     0  56.1M      0  0:00:13  0:00:10  0:00:03 53.3M
 84  737M   84  621M    0     0  56.4M      0  0:00:13  0:00:11  0:00:02 52.7M
 93  737M   93  686M    0     0  57.1M      0  0:00:12  0:00:12 --:--:-- 55.1M
 99  737M   99  736M    0     0  56.6M      0  0:00:13  0:00:13 --:--:-- 56.1M
100  737M  100  737M    0     0  56.7M      0  0:00:13  0:00:13 --:--:-- 55.9M

C:\Users\circleci\project>goto cuda_common 

C:\Users\circleci\project>if not exist "C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\NvToolsExt.7z" (
curl -k -L https://www.dropbox.com/s/9mcolalfdj4n979/NvToolsExt.7z?dl=1 --output "C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\NvToolsExt.7z"  
 if errorlevel 1 exit /b 1 
) 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   137    0   137    0     0    137      0 --:--:-- --:--:-- --:--:--   439

100   320  100   320    0     0    320      0  0:00:01 --:--:--  0:00:01   320

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  108k  100  108k    0     0   108k      0  0:00:01 --:--:--  0:00:01 1394k

C:\Users\circleci\project>echo Installing CUDA toolkit... 
Installing CUDA toolkit...


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm, looks good to me.

@prabhat00155 prabhat00155 merged commit 30f4d10 into pytorch:main Nov 16, 2021
@github-actions
Copy link

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@frgfm frgfm deleted the pil-version branch November 16, 2021 13:19
@datumbox
Copy link
Contributor

datumbox commented Nov 16, 2021

@frgfm I think we missed a few more places where the version is defined like here:

etc

cc @pmeier this links to the multiple dependency definition discussed on the other issue.

cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
…ge mode = P (pytorch#4939)

* chore: Updated pillow version specifier

* docs: Updated issue ref in comment
@frgfm
Copy link
Contributor Author

frgfm commented Nov 16, 2021

@datumbox my bad I didn't know about those, I'll open a PR

For the long run, regarding dependency specifier consistency, I had the same on a simpler project. I ended up implementing a python test to parse all of those and notify me when there are issues: https://github.com/frgfm/torch-cam/blob/master/tests/test_requirements.py

It supports "requirements.txt" and "setup.py", so it cannot be used as is in this case, but we could try to implement something similar?

@datumbox
Copy link
Contributor

@frgfm Thanks! Concerning the dependency consistency, there is a parallel thread discussing this at #4917

facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
… when image mode = P (#4939)

Summary:
* chore: Updated pillow version specifier

* docs: Updated issue ref in comment

Reviewed By: datumbox

Differential Revision: D32470471

fbshipit-source-id: 044c3ed78748166f0837fcc5632703c417afd95e
knao124 added a commit to knao124/fastlabel-python-sdk that referenced this pull request Sep 2, 2022
qoone pushed a commit to fastlabel/fastlabel-python-sdk that referenced this pull request Sep 22, 2022
takahiro-tamenishi pushed a commit to fastlabel/fastlabel-python-sdk that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[transforms] Troubles with padding for PIL image in mode P
5 participants