Add numpy as explicit dependency to build_cmake.sh #4987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it `setuptools.py` will try to install latest, which is not compatible with Python runtime older than 3.8 Fixes #4985
💊 CI failures summary and remediationsAs of commit fefc4ef (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
seemethere
reviewed
Nov 24, 2021
| fi | ||
|
|
||
| conda install -yq \pytorch=$PYTORCH_VERSION $CONDA_CUDATOOLKIT_CONSTRAINT $PYTORCH_MUTEX_CONSTRAINT $MKL_CONSTRAINT -c "pytorch-${UPLOAD_CHANNEL}" | ||
| conda install -yq \pytorch=$PYTORCH_VERSION $CONDA_CUDATOOLKIT_CONSTRAINT $PYTORCH_MUTEX_CONSTRAINT $MKL_CONSTRAINT numpy -c "pytorch-${UPLOAD_CHANNEL}" |
There was a problem hiding this comment.
Should we pin it to something?
There was a problem hiding this comment.
No need I guess, as it should be compatible with all the tests in question
|
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Summary: Otherwise, it `setuptools.py` will try to install latest, which is not compatible with Python runtime older than 3.8 Fixes #4985 Reviewed By: NicolasHug Differential Revision: D32694306 fbshipit-source-id: dab48870e25bf077d6e1c1c3edd6da541971ece7
datumbox
pushed a commit
to datumbox/vision
that referenced
this pull request
Dec 8, 2021
Otherwise, it `setuptools.py` will try to install latest, which is not compatible with Python runtime older than 3.8 Fixes pytorch#4985
datumbox
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it
setuptools.pywill try to install latest, which is not compatible with Python runtime older than 3.8Fixes #4985
cc @seemethere