Skip to content

Mark CircleCI weight downloads with source=ci #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

Mark CircleCI weight downloads with source=ci #4998

merged 1 commit into from
Nov 29, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 27, 2021 •
edited by pytorch-probot bot
Loading

Mark model weight downloads from CircleCI with a URL param.

cc @seemethere @bjuncek

@datumbox datumbox requested a review from pmeier November 27, 2021 14:40
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 27, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3305e8b (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox marked this pull request as draft November 27, 2021 14:48
@datumbox datumbox force-pushed the ci/weight_param_url branch from eab211c to 3305e8b Compare November 27, 2021 15:50
@datumbox datumbox marked this pull request as ready for review November 27, 2021 15:52
pmeier
pmeier approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @datumbox!

@datumbox datumbox merged commit bca7957 into pytorch:main Nov 29, 2021
@datumbox datumbox deleted the ci/weight_param_url branch November 29, 2021 09:46
facebook-github-bot pushed a commit that referenced this pull request Nov 30, 2021
@prabhat00155 @facebook-github-bot
[fbsync] Mark CircleCI downloads with source=ci (#4998)
9a6952e 
Reviewed By: NicolasHug

Differential Revision: D32694299

fbshipit-source-id: 1b50f6f796a0990848840d0347f53a9d04462b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: ci prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @facebook-github-bot @pmeier