Add bias parameter to ConvNormActivation #5012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 373652b (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
approved these changes
Nov 30, 2021
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
prabhat00155
reviewed
Dec 1, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
Summary: * Add bias parameter to ConvNormActivation * Update torchvision/ops/misc.py Reviewed By: NicolasHug Differential Revision: D32759197 fbshipit-source-id: 08490a7a64c3e39337e32ff53fea111fdd5ee7bd Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
biasparameter toConvNormActivation. The current behaviour inmainis to add a bias if there's no normalization layer, but in some cases like in RAFT, we need the biases even though there is a norm layer. For details, see: https://github.com/NicolasHug/vision/blob/5f58ec164f6cce45c155815ab5f845d4773fad94/torchvision/models/video/_raft/raft.py#L15